> On April 17, 2017, 8:36 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Line 52 (original), 52 (patched) > > <https://reviews.apache.org/r/58489/diff/1/?file=1693394#file1693394line52> > > > > Why would service_name be the string "null"? > > Madhuvanthi Radhakrishnan wrote: > During install_packages roleCommand, the service name is set to "null" > /var/lib/ambari-agent/data/command-5.json: "serviceName": "null",
If serviceName is the string "null" then that's pretty lame. :) That should be fixed. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/#review172160 ----------------------------------------------------------- On April 17, 2017, 8:31 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > ----------------------------------------------------------- > > (Updated April 17, 2017, 8:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-20775 > https://issues.apache.org/jira/browse/AMBARI-20775 > > > Repository: ambari > > > Description > ------- > > All the commands.json files should always contain the versionAdvertised > field. If versionAdvertised is not set in command.json then we should assume > that versionAdvertised=False when calling stack_tools.py > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 93ec0b74f5 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 03f53d490b > > > Diff: https://reviews.apache.org/r/58489/diff/1/ > > > Testing > ------- > > Tested for service actions: > Start > Stop > Restart > Reconfigure > Service Check > Enable HA > > > Thanks, > > Madhuvanthi Radhakrishnan > >
