----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58591/#review172589 -----------------------------------------------------------
Ship it! Ship It! - Alexandr Antonenko On April 20, 2017, 8:34 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58591/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 8:34 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Di Li, Richard Zang, and > Sangeeta Ravindran. > > > Bugs: AMBARI-20810 > https://issues.apache.org/jira/browse/AMBARI-20810 > > > Repository: ambari > > > Description > ------- > > Roles page in Ambari UI shows extra empty rows in Internet explorer. > > javascript For..each loop doesn't work as expected for arrays in Internet > explorer, which causes the extra rows as in screenshot. > > > Diffs > ----- > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js > e1b74aa > > > Diff: https://reviews.apache.org/r/58591/diff/1/ > > > Testing > ------- > > tested manually, verified in different browsers (IE/firefox/chrome) > > > File Attachments > ---------------- > > After fix > > https://reviews.apache.org/media/uploaded/files/2017/04/20/d891ffb5-e048-4c4c-9b50-dca3bab48ba2__Afterfix.jpg > Before fix > > https://reviews.apache.org/media/uploaded/files/2017/04/20/a6915f9d-d69b-4dda-9e3b-6cfd338cb815__UI.jpg > > > Thanks, > > Anita Jebaraj > >
