----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58801/ -----------------------------------------------------------
(Updated April 27, 2017, 2:34 p.m.) Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. Changes ------- Update for comments and test fixes. Bugs: AMBARI-20871 https://issues.apache.org/jira/browse/AMBARI-20871 Repository: ambari Description ------- We have 2 different ways of creating repositories - one is creating a new file for each repo definition (standard installation) and one file containing multiple repo definitions (install_packages). These should both be done the same way (the install_packages way). Diffs (updated) ----- ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java PRE-CREATION ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 8c726a0f2d ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 74a2cf2e32 ambari-server/src/main/java/org/apache/ambari/server/bootstrap/DistributeRepositoriesStructuredOutput.java 662b856c05 ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java 3681eda976 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d556b603a8 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java ab8b65968e ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 751ce085d8 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java e39588ed42 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 811ce9b8cb ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java fdb7c8d9b8 ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 33adce1414 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 6193c11c22 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py a35dce757e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java 8f7b31ddea ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java 4bed482f8d ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java c6ee87588c ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java df69f68f6c ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java 3a5532b08d ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee3f6 ambari-server/src/test/python/custom_actions/configs/install_packages_repository_file.json PRE-CREATION ambari-server/src/test/python/stacks/2.0.6/configs/repository_file.json PRE-CREATION ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 082d2001cf Diff: https://reviews.apache.org/r/58801/diff/2/ Changes: https://reviews.apache.org/r/58801/diff/1-2/ Testing ------- Manual for both centos6 and ubuntu14. Automated pending. Thanks, Nate Cole