----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58887/#review173496 -----------------------------------------------------------
Ship it! Ship It! - DIPAYAN BHOWMICK On May 1, 2017, 7:16 p.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58887/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 7:16 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20906 > https://issues.apache.org/jira/browse/AMBARI-20906 > > > Repository: ambari > > > Description > ------- > > So from logs it looks like the problem happens when the "view directory > watcher" detects change in jar file tries to update the view. > The solution to this is not with proof but a precautionary and preventive of > nature. > I have introduced a property "views.directory.watcher.disable" which can be > set to "true" to disable the View Directory Watcher. > Disabling will help if ambari does not work fine even after restarts. Another > small change is that I have done the method in ViewRegistry to be > synchronized. This will remove cases if any where in the view gets > simultaneously updated. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > f01df9be7d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > e266dd5693 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 24eceb21c6 > > > Diff: https://reviews.apache.org/r/58887/diff/1/ > > > Testing > ------- > > Tests cases are clearing. And ambari is coming up properly. > > > Thanks, > > Nitiraj Rathore > >
