> On May 3, 2017, 3:37 a.m., Alejandro Fernandez wrote: > > Ship It!
Thank you very much! - Masahiro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review173621 ----------------------------------------------------------- On April 17, 2017, 9:40 a.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57687/ > ----------------------------------------------------------- > > (Updated April 17, 2017, 9:40 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku > Sako. > > > Bugs: AMBARI-20443 > https://issues.apache.org/jira/browse/AMBARI-20443 > > > Repository: ambari > > > Description > ------- > > In Advanced hive-env, there is a parameter named hive_ambari_database. Though > I change the parameter, it looks like nothing has changed. I greped the > entire ambari source code, the parameter is not referenced. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 5f56617 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 4ed26f7 > > > Diff: https://reviews.apache.org/r/57687/diff/3/ > > > Testing > ------- > > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12863418/AMBARI-20443.3.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 core tests. The patch passed unit tests in ambari-server. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/11398//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/11398//console > > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
