-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58963/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-20918
    https://issues.apache.org/jira/browse/AMBARI-20918


Repository: ambari


Description
-------

The problem is that `Configuration.AMBARISERVER_METRICS_DISABLE` is a 
`ConfigurationProperty<Boolean>`, not a `[Bb]oolean`, so it never 
`equals(true)`.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 ff20834c1a26611206e2839b1c877503eb434084 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 bc6b4281338ff1457b0b404c4ac6d664e32af108 


Diff: https://reviews.apache.org/r/58963/diff/1/


Testing
-------

Started Ambari Server with 3 possible states of the flag:

 * no `ambariserver.metrics.disable` in `ambari.properties`
 * `ambariserver.metrics.disable=true`
 * `ambariserver.metrics.disable=false`


Thanks,

Attila Doroszlai

Reply via email to