----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59053/#review174203 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On May 8, 2017, 4:31 p.m., Diego Santesteban wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59053/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 4:31 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-20946 > https://issues.apache.org/jira/browse/AMBARI-20946 > > > Repository: ambari > > > Description > ------- > > I added an extra case in resourceFilesKeeper.py to recreate the archive.zip > file if it doesn't exist, even when the saved and current directory hashes > are matching. > > I added one new test case to make sure this case is working, and modified one > existing test case to make it specific for the other case (where the > archive.zip file does exist and the hashes match). > > > Diffs > ----- > > ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py > dba6833924 > ambari-server/src/test/python/TestResourceFilesKeeper.py 4f7dc525d3 > > > Diff: https://reviews.apache.org/r/59053/diff/1/ > > > Testing > ------- > > I created a new test case and successfully ran all tests with 'mvn clean > test'. > > I also applied this change to an existing cluster to ensure that it does fix > the issue in a real usage case. > > > Thanks, > > Diego Santesteban > >
