----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/#review174498 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On May 10, 2017, 5:10 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59104/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 5:10 p.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-20970 > https://issues.apache.org/jira/browse/AMBARI-20970 > > > Repository: ambari > > > Description > ------- > > - Documented StackssService (except 3 calls that return other services - > Swagger can't handle them out of the box) > - Some inaccuracies on the response schema (e.g. Artifact and Configuration > queries use the same response object, so service_name is reported for the > stack level API call) > - subresources are partially covered > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java > 76d2b70 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > 7b5f9cf > > ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java > 86bacf1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java > 47515c9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java > 8e87e6f > > ambari-server/src/main/java/org/apache/ambari/server/controller/ComponentDependencyResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ExtensionLinkResponse.java > 99c9ce9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/QuickLinksResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackArtifactResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java > 14aab3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java > 0338ed9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackResponse.java > 1901337 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceArtifactResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java > b48fad3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > 8e4200d > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java > 3c65d05 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ThemeResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ViewInstanceResponse.java > d0a5206 > > ambari-server/src/main/java/org/apache/ambari/server/state/QuickLinksConfigurationInfo.java > d4bdce8 > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 353dd86 > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java > c41cd9a > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java > 7824933 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java > a28d149 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigPlacement.java > 3bb8c77 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Layout.java > 840dbf0 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Section.java > 43d2170 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Subsection.java > 62fbfc1 > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Tab.java > b949a12 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java > f7d4187 > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Theme.java > 96d2fc0 > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java > 58fe942 > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Unit.java > 7bd058c > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/Widget.java > 1f38d8e > > ambari-server/src/main/java/org/apache/ambari/server/state/theme/WidgetEntry.java > 9e9c068 > docs/api/generated/swagger.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/59104/diff/3/ > > > Testing > ------- > > All unit tests for ambari-server pass, except ServicePropertiesTest, which > fails due to AMBARI-20443. > > > Thanks, > > Balázs Bence Sári > >
