----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/ -----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-21052 https://issues.apache.org/jira/browse/AMBARI-21052 Repository: ambari Description ------- In the Register Version UI, the regex pattern for Version Number is currently hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two digits to be entered to make it a valid 4 digit stack version. If the stack version dir has three digits, Register Version UI throws an error mystack-x.x.x Invalid. The regex pattern should be based on the number of digits supplied by the stack's version dir and should not be harcoded. Diffs (updated) ----- ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 69c35c0 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js fd2c6e5 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js b496987 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html fe08802 ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js 81d3441 Diff: https://reviews.apache.org/r/59382/diff/1/ Testing (updated) ------- Manual Testing. I updated the test case because $scope.subversionPattern has been removed as part of this fix. Thanks, Sangeeta Ravindran