> On June 1, 2017, 9:18 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py > > Lines 121-125 (patched) > > <https://reviews.apache.org/r/59626/diff/2/?file=1737369#file1737369line121> > > > > Wouldn't installed always be a subset of available? Taking CentOS as an > > example with ZooKeeper installed, I get this: > > > > ``` > > Available: > > zookeeper.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1 > > zookeeper-server.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1 > > > > Installed: > > zookeeper_2_5_0_0_1237.noarch 3.4.6.2.5.0.0-1237.el6 @HDP-2.5-repo-1 > > zookeeper_2_5_0_0_1237-server.noarch 3.4.6.2.5.0.0-1237.el6 > > @HDP-2.5-repo-1 > > ``` > > > > So my final list would look like: > > zookeeper.noarch > > zookeeper-server.noarch > > zookeeper_2_5_0_0_1237.noarch > > zookeeper_2_5_0_0_1237-server.noarch > > > > This would then return the first match. But, if I have another repo > > registered on here so that my list was: > > > > zookeeper_2_6_0_0_9999.noarch > > zookeeper_2_6_0_0_9999-server.noarch > > zookeeper.noarch > > zookeeper-server.noarch > > zookeeper_2_5_0_0_1237.noarch > > zookeeper_2_5_0_0_1237-server.noarch > > > > Wouldn't it return the wrong one to install?
that is not a case for all OSs - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176640 ----------------------------------------------------------- On June 1, 2017, 5:22 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59626/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 5:22 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-21091 > https://issues.apache.org/jira/browse/AMBARI-21091 > > > Repository: ambari > > > Description > ------- > > We decided to select exact package version by looking through repository for > target stack. > Also other minor fixes > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py > 8a15ee5ec5 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 054490b03e > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 975d6a63d8 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java > 8bfafd34bf > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > c12dff16b1 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > 35fffda001 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py > 5f5576e3e7 > > ambari-server/src/test/python/custom_actions/configs/install_packages_config.json > c6575b51a7 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > fda63e099a > ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json > 51476031d8 > > > Diff: https://reviews.apache.org/r/59626/diff/2/ > > > Testing > ------- > > Live cluster tests > > > Thanks, > > Dmitro Lisnichenko > >
