----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59149/#review177245 -----------------------------------------------------------
Ship it! Ship It! - Aravindan Vijayan On June 1, 2017, 6:52 p.m., Qin Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59149/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 6:52 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Di Li, Dmytro Sen, Robert > Levas, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-19369 > https://issues.apache.org/jira/browse/AMBARI-19369 > > > Repository: ambari > > > Description > ------- > > This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to > authenticate". > > In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari > Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But > Hadoop/hbase/kafka/storm sinks, clients of Ambari Metrics Collector, > currently do not support Kerberos HTTP SPNEGO authentication. > > e.g., > /var/log/hadoop-yarn/yarn/yarn-yarn-timelineserver-<timelineserver-host>.log: > 2016-12-16 22:25:29,471 INFO timeline.HadoopTimelineMetricsSink > (AbstractTimelineMetricsSink.java:emitMetricsJson(169)) - Unable to POST > metrics to collector, http://metrics-collector:6188/ws/v1/timeline/metrics, > statusCode = 401 > > > Diffs > ----- > > ambari-metrics/ambari-metrics-common/pom.xml 62ae75f > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > 2c6fae2 > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java > PRE-CREATION > > ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManagerTest.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml > db36db8 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2 > a93c36c > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2 > 7097481 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2 > a93c36c > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2 > 7097481 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/configuration/hbase-env.xml > da12706 > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_master_jaas.conf.j2 > a93c36c > > ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/package/templates/hbase_regionserver_jaas.conf.j2 > 7097481 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py > d9b62e2 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_dn_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jn_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_nn_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs.py > d9b62e2 > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_dn_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jn_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_nn_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml > 91af58e > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml > fdde8f2 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/templates/kafka_jaas.conf.j2 > 56c558d > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_yaml_utils.py > 9d78e71 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm_jaas.conf.j2 > c22cb51 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 3579fcb > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > 2e1b208 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/mapred_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_ats_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2 > 483c815 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_nm_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration-mapred/mapred-env.xml > 07cfafe > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml > 6a52865 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py > 66194ed > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py > c6b4c18 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/mapred_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_ats_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_jaas.conf.j2 > 483c815 > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_nm_jaas.conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-env.xml > 869f44a > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/hbase-env.xml > d2b3671 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml > 1bfd2fe > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml > 190684c > > ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml > 1bfd2fe > > ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml > 9d504db > > ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration-mapred/mapred-env.xml > a143660 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 5702b57 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 2202661 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 01149fb > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py b8fee12 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 9e9366d > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 127a045 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 53218d5 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py > b05d9f2 > ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 6fc5bae > ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py > ed5ee2c > ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 8873fbf > > > Diff: https://reviews.apache.org/r/59149/diff/3/ > > > Testing > ------- > > The existing unit testcases has been updated to reflect the changes. > The fix has been manually tested via HDP/trunk (currently, Ambari-Metrics > spnego support is disabled and you have to enable it manually). > > > Thanks, > > Qin Liu > >
