> On 六月 16, 2017, 11:54 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-log4j.xml > > Lines 95 (patched) > > <https://reviews.apache.org/r/59877/diff/1/?file=1743755#file1743755line95> > > > > I didn't catch this earlier, is this really ment to be added when > > Ambari is upgraded regardless of the stack version? > > > > What should happen during a stack upgrade?
Thank you for your advice.I take a look at this parameter and find that when ambari is going to be upgraded,the properties of new_configs which contains the "<on-ambari-upgrade add="true"/> will be added in new Stack while the old configs doesn't contains those prpoerties.So,I think it's better to add this. - wang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59877/#review178140 ----------------------------------------------------------- On 六月 7, 2017, 10:46 a.m., wang jianfei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59877/ > ----------------------------------------------------------- > > (Updated 六月 7, 2017, 10:46 a.m.) > > > Review request for Ambari, Dmytro Sen, Jaimin Jetly, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-21191 > https://issues.apache.org/jira/browse/AMBARI-21191 > > > Repository: ambari > > > Description > ------- > > Currently,if you want to config log4j.properties of Flume,you must change the > log4j.properties.j2 in the ambari-agent-host installed flume-agent. > So,we make it configurable by adding log4j.properties.template. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/configuration/flume-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py > 6b1d286 > > > Diff: https://reviews.apache.org/r/59877/diff/1/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > wang jianfei > >
