----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60389/#review178798 -----------------------------------------------------------
Ship it! The patch looks fine to me. Can you also please add Alejandro to the reviewer list? Thanks. - Robert Nettleton On June 23, 2017, 1:54 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60389/ > ----------------------------------------------------------- > > (Updated June 23, 2017, 1:54 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-21333 > https://issues.apache.org/jira/browse/AMBARI-21333 > > > Repository: ambari > > > Description > ------- > > Extract Log Search service advisor from the stack advisor. > Also created an empty Ambari Infra service advisor. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 726514b > > > Diff: https://reviews.apache.org/r/60389/diff/1/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Miklos Gergely > >
