----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60435/ -----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sid Wagle. Bugs: AMBARI-21346 https://issues.apache.org/jira/browse/AMBARI-21346 Repository: ambari Description ------- When attempting to begin an upgrade between stack versions from different vendors (ie HDP and BigInsights), various steps will fail because the Ambari Server code assumes that the stack name is not changing. Therefore, actions like finding the right upgrade pack will fail with a NullPointerException {code} java.lang.NullPointerException at org.apache.ambari.server.state.UpgradeContext.setSourceAndTargetStacks(UpgradeContext.java:277) {code} We can work around this temporarily by falling back to querying by the version number directly. Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/UpgradeEventCreator.java 456aa00df4 ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java dd0086a887 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java 26f96e8235 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 4e6451eb19 ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 71fb5d9815 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/UpgradeEventCreatorTest.java 57074fd448 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java 36889b2bb7 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 83da3a2766 Diff: https://reviews.apache.org/r/60435/diff/1/ Testing ------- PENDING Thanks, Jonathan Hurley