----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60586/#review179555 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java Line 369 (original), 371 (patched) <https://reviews.apache.org/r/60586/#comment254320> `StackId.equals` also compares version, so inequality does not imply cross-stack downgrade, does it? ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java Line 133 (original), 131 (patched) <https://reviews.apache.org/r/60586/#comment254328> Shouldn't this check `sourceStackId` instead of `targetStackId`? Also, why restrict the check to downgrade? - Attila Doroszlai On July 4, 2017, 6:40 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60586/ > ----------------------------------------------------------- > > (Updated July 4, 2017, 6:40 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-21391 > https://issues.apache.org/jira/browse/AMBARI-21391 > > > Repository: ambari > > > Description > ------- > > During an EU, the effective stack ID needs to be correctly determined based > on whether the desired stack has changed. > > STR: > - Create a stack with BIgInsights 4.2.5 > - Register HDP 2.6 > - Perform an EU > > The "STOP" steps should be sending down host_params/stack_version = 4.2.5.0. > All commands after the desired stack ID change should adjust to using the > target (HDP 2.6) value. > > {code} > "configuration_credentials": {}, > "roleCommand": "CUSTOM_COMMAND", > "credentialStoreEnabled": "false", > "hostLevelParams": { > "stack_name": "BigInsights", > "current_version": "4.2.5.0-0000", > "custom_command": "RESTART", > "stack_version": "4.2.5", > ... > }, > "commandParams": { > "upgrade_direction": "upgrade", > "service_package_folder": "common-services/ZOOKEEPER/3.4.5/package", > "hooks_folder": "HDP/2.0.6/hooks", > "clusterName": "c1", > "script": "scripts/zookeeper_server.py", > "request_id": "10", > "version": "2.6.0.0-334", > "forceRefreshConfigTagsBeforeExecution": "true", > "upgrade_type": "nonrolling_upgrade", > "command_timeout": "900", > "script_type": "PYTHON" > }, > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 25e8cab4a4 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 2fc492bfba > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java > cca87bc874 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 1bb3d77d8d > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > c4f28b2ab0 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > 9ca0d4e9ee > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 3a2616409a > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > 46949eaa97 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 8b1f4effb0 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java > 9bb9b4597f > > > Diff: https://reviews.apache.org/r/60586/diff/2/ > > > Testing > ------- > > Most UTs passing now. > > > Thanks, > > Jonathan Hurley > >
