----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60845/ -----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. Bugs: AMBARI-21468 https://issues.apache.org/jira/browse/AMBARI-21468 Repository: ambari Description ------- Knox fails the restart during EU with error """ resource_management.core.exceptions.ExecutionFailed: Execution of 'cp -R -p -f /usr/hdp/4.2.0.0/knox/data/. /usr/hdp/current/knox-server/data' returned 1. cp: cannot stat '/usr/hdp/4.2.0.0/knox/data/.': No such file or directory """ This is because the common service Knox Py script assumes data dir is under stack_root which is /usr/hdp by the time it's Knox to restart during EU. But it also attaches the "current_version" obtained from command json file that points to 4.2.0.0 (or 4.2.5.0-0000) for the migration cluster. So the result root dir /usr/hdp/4.2.xxxx does not exist. """ ambari-server\src\main\resources\common-services\KNOX\0.5.0.2.2\package\scripts\upgrade.py <stack-root>/2.3.0.0-1234/knox/data/. source_data_dir = os.path.join(params.stack_root, params.upgrade_from_version, "knox", "data", ".") ambari-server\src\main\resources\common-services\KNOX\0.5.0.2.2\package\scripts\params_linux.py upgrade_from_version = default("/hostLevelParams/current_version", None) """ """ "hostLevelParams": { "agent_stack_retry_on_unavailability": "false", "stack_name": "HDP", "group_list": "[\"spark\",\"hadoop\",\"users\",\"knox\"]", "host_sys_prepped": "false", "ambari_db_rca_username": "mapred", "current_version": "4.2.0.0", """ Diffs ----- ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 5a2ef19 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 917f340 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 8912322 ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml f3c73a0 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 3f6962b ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 4867626 Diff: https://reviews.apache.org/r/60845/diff/1/ Testing ------- to be tested in integrated tests during the migration. Thanks, Di Li