-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60975/
-----------------------------------------------------------

(Updated July 19, 2017, 2:34 p.m.)


Review request for Ambari, Alejandro Fernandez and Robert Levas.


Changes
-------

Added UT


Bugs: AMBARI-21522
    https://issues.apache.org/jira/browse/AMBARI-21522


Repository: ambari


Description
-------

When installing a new cluster with Atlas, the cluster's version may not 
transition out of {{INIT}}.

This is being caused by Atlas Client - it's version is UNKNOWN.

{code}
ATLAS_CLIENT    UNKNOWN 6       INSTALLED       2       ATLAS
HST_AGENT       UNKNOWN 6       STARTED 2       SMARTSENSE
INFRA_SOLR_CLIENT       UNKNOWN 6       INSTALLED       2       AMBARI_INFRA
LOGSEARCH_LOGFEEDER     UNKNOWN 6       STARTED 2       LOGSEARCH
METRICS_COLLECTOR       UNKNOWN 6       STARTED 2       AMBARI_METRICS
METRICS_GRAFANA UNKNOWN 6       STARTED 2       AMBARI_METRICS
METRICS_MONITOR UNKNOWN 6       STARTED 2       AMBARI_METRICS
{code}

This is an HDP-2.6 cluster, which means that Atlas should be using 0.7.0.2.5:
{code}
./src/main/resources/common-services/ATLAS/0.7.0.2.5/metainfo.xml:      
<version>0.7.0.2.5</version>
./src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml:      
<version>0.7.0.2.5</version>
./src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml:      
<extends>common-services/ATLAS/0.7.0.2.5</extends>
{code}

In Atlas 0.7.0.2.5, it advertises a version:
{code}
        <component>
          <name>ATLAS_CLIENT</name>
          <cardinality>1+</cardinality>
          <versionAdvertised>true</versionAdvertised>
        </component>
      </components>
{code}

The root cause is that the verison is not being sent in the {{commandParams}}:
{code}
2017-07-19 15:43:49,739 - Stack Feature Version Info: Cluster Stack=2.6, 
Cluster Current Version=None, Command Stack=None, Command Version=None-> 2.6
{code}


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 88753142f1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 cccb4b2a93 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
 2376ff9ca7 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 bdc9ec4dc8 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapperTest.java
 c28ba5d8a9 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 085b7468d7 


Diff: https://reviews.apache.org/r/60975/diff/3/

Changes: https://reviews.apache.org/r/60975/diff/2-3/


Testing (updated)
-------

Performaed blueprint and web-client based installations with and without 
version info set correctly on the VDF.

Tests run: 5002, Failures: 0, Errors: 0, Skipped: 39

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24:11 min
[INFO] Finished at: 2017-07-19T14:24:16-04:00
[INFO] Final Memory: 71M/1038M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley

Reply via email to