----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61045/ -----------------------------------------------------------
Review request for Ambari, Robert Levas and Sid Wagle. Bugs: AMBARI-21552 https://issues.apache.org/jira/browse/AMBARI-21552 Repository: ambari Description ------- When querying for upgrade pre-checks, the target stack version and name are required now. It's simple to just supply the repository ID in this case as it contains all relevant information and prevents a NamedQuery lookup. The new query should look like: ``` GET api/v1/clusters/c1/rolling_upgrades_checkfields=*& UpgradeChecks/repository_version_id=2& UpgradeChecks/upgrade_type=ROLLING ``` Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java f80c16afcc ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java 7b03912985 ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 0ab22637f1 ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 5fdcd663b6 ambari-server/src/test/java/org/apache/ambari/server/checks/AtlasPresenceCheckTest.java c8330262ad ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java c5359789cd ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentExistsInRepoCheckTest.java 76e8cc9277 ambari-server/src/test/java/org/apache/ambari/server/checks/ComponentsInstallationCheckTest.java 450d74edb9 ambari-server/src/test/java/org/apache/ambari/server/checks/ConfigurationMergeCheckTest.java 68a052236a ambari-server/src/test/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheckTest.java cdf13ebe42 ambari-server/src/test/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheckTest.java 16f383ae97 ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java cc2c2764b6 ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java 9fcb319d53 ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java 433eee1ad7 ambari-server/src/test/java/org/apache/ambari/server/checks/InstallPackagesCheckTest.java 986a0f113a ambari-server/src/test/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheckTest.java efcf3de433 ambari-server/src/test/java/org/apache/ambari/server/checks/PreviousUpgradeCompletedTest.java 3233e553a6 ambari-server/src/test/java/org/apache/ambari/server/checks/ServicePresenceCheckTest.java 03b0e81bd9 ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java a941b7ab09 ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheckTest.java 87d41677ee ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java 65505fa474 ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java 5c423b5308 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java 2a48fa6882 ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 8cf73734cb Diff: https://reviews.apache.org/r/61045/diff/1/ Testing ------- mvn clean test Thanks, Jonathan Hurley