> On Aug. 8, 2017, 1:31 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Line 249 (original), 255 (patched) > > <https://reviews.apache.org/r/61490/diff/1/?file=1791665#file1791665line267> > > > > could we put here some usefull information about request and kind of > > error occurs?
Actually, I just dropped the try/catch since all invokers of this expect AmbariException anyway. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/#review182361 ----------------------------------------------------------- On Aug. 7, 2017, 11:48 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61490/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2017, 11:48 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-21677 > https://issues.apache.org/jira/browse/AMBARI-21677 > > > Repository: ambari > > > Description > ------- > > With {{PATCH}} and {{SERVICE}} style upgrades, many of the upgrade pre-checks > would flag issues related to services or hosts which may not be a part of the > upgrade. If the upgrade is not a full-stack upgrade, then warnings and errors > related to services which are not part of the upgrade should be ignored. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 4f8a39d8a5 > > ambari-server/src/main/java/org/apache/ambari/server/checks/AtlasPresenceCheck.java > 04b73fa160 > > ambari-server/src/main/java/org/apache/ambari/server/checks/AutoStartDisabledCheck.java > c41ad207a5 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java > 226d82c049 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsExistInRepoCheck.java > d60433d141 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java > a77d72b520 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java > 28d7d7884a > > ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java > 8feb77a8dd > > ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java > c2ef4ad337 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HiveMultipleMetastoreCheck.java > ea20a5535b > > ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java > 2b1c62ede2 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java > 8cd935bf1f > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java > 613c5fc431 > > ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java > 7c84e5c630 > > ambari-server/src/main/java/org/apache/ambari/server/checks/KafkaKerberosCheck.java > 69721d9e3c > > ambari-server/src/main/java/org/apache/ambari/server/checks/MapReduce2JobHistoryStatePreservingCheck.java > 06ca1629ce > > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerAuditDbCheck.java > ec4ed09da4 > > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java > a55a1481d6 > > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerSSLConfigCheck.java > 02f6559fe4 > > ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java > 0dbb1b5da1 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java > 08f4fd8eed > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java > 3970e9e698 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java > 38a6702b2e > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeTruncateCheck.java > 35be754bdf > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java > 5dadcddc20 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java > d838f6a20e > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java > 77605c1835 > > ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java > b5435f1830 > > ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java > 9dd4877ae6 > > ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java > ba4b61e078 > > ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java > 8f15479a24 > > ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java > a96ca6c4a3 > > ambari-server/src/test/java/org/apache/ambari/server/checks/KafkaKerberosCheckTest.java > 41962f9594 > > > Diff: https://reviews.apache.org/r/61490/diff/1/ > > > Testing > ------- > > PENDING > > > Thanks, > > Jonathan Hurley > >
