> On Aug. 8, 2017, 8:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > > Lines 165 (patched) > > <https://reviews.apache.org/r/61024/diff/3/?file=1793035#file1793035line165> > > > > What are the performance implications? > > > > Is this invoked on every call?
It has to be invoked in every call. It takes 1-2 millis in my local environment. > On Aug. 8, 2017, 8:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > > Lines 184 (patched) > > <https://reviews.apache.org/r/61024/diff/3/?file=1793035#file1793035line184> > > > > Why is this issuing an HTTP call instead of calling the method directly > > to make it more efficient? It is not going through http, but calls the rest service endpoint. I copied the existing style of similar methods (getServicesInformation and getHostsInformation) in the class. Performance impact is negligible. - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/#review182428 ----------------------------------------------------------- On Aug. 8, 2017, 5:57 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61024/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 5:57 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and > Sebastian Toader. > > > Bugs: AMBARI-21545 > https://issues.apache.org/jira/browse/AMBARI-21545 > > > Repository: ambari > > > Description > ------- > > Ldap configuration can be included in recommendation requests and validation > requests. Configuration is passed down to stack advisor in services.json > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java > d6714f9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java > 0632361 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java > 7ba1b18 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 356754d > > ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java > eaa4716 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java > 6df8b8b > > > Diff: https://reviews.apache.org/r/61024/diff/3/ > > > Testing > ------- > > - Tested the rest interface manually > - Wrote new unit tests > - Ambari-server unit tests: PENDING > > > Thanks, > > Balázs Bence Sári > >
