----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61996/#review184187 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Aug. 30, 2017, 6:10 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61996/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 6:10 p.m.) > > > Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert > Nettleton. > > > Bugs: AMBARI-21857 > https://issues.apache.org/jira/browse/AMBARI-21857 > > > Repository: ambari > > > Description > ------- > > Add new pom.xml file for the new logsearch web ui in order to package static > resources in jar (which are generated with yarn and angular-cli) > > The resource generation flow is the following: > - install (download or copy an already downloaded one) node and yarn in > target/webapp-build folder > - copy source files from the ui root folder into target/webapp-build > - run yarn install, then yarn build-prod > - copy target/webapp-build/dist to target/classes/dist > - during package phase target/classes content included in the generated jar > > Next steps from here: > Add the new ui dependency to logsearch server, during the logsearch portal > build, the dist static content will be packaged with the server files. > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-web-new/package.json b4902a3 > ambari-logsearch/ambari-logsearch-web-new/pom.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/61996/diff/1/ > > > Testing > ------- > > done, manually, generated jar contains "dist/" folder. anyway, no mvn clean > test support yet. > > > Thanks, > > Oliver Szabo > >
