----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61949/ -----------------------------------------------------------
(Updated Aug. 31, 2017, 8:06 p.m.) Review request for Ambari, Jonathan Hurley and Nate Cole. Changes ------- Addressed Nate's comments Bugs: AMBARI-21832 https://issues.apache.org/jira/browse/AMBARI-21832 Repository: ambari Description ------- Currently there is an odd scenario which can occur when patch repositories are registered which have services not yet installed. Consider the following scenario: - Install ZooKeeper, Storm on HDP 2.6.0.0-1234 - Register/patch a {{PATCH}} VDF for Storm and Accumulo for 2.6.0.1-9999 - Install Accumulo Which version does Accumulo use - the {{STANDARD}} repository or the {{PATCH}}? If the {{PATCH}} repository is chosen, this will now prevent reversion of the patch since there's no prior version for Accumulo to revert back to. If Accumulo uses the {{STANDARD}} repo, then there needs to be a lot of design and UX flow work provided to indicate that a {{PATCH}} which was previously applied can be re-applied for the new service. This also causes problems for patch reversion since now there would be two upgrades which need to be reverted to "get rid" of the patch. For the timeframe for Ambari 2.6, we should reject VDFs that include services which are not installed. This will prevent the problem. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 7a53e91bb0 Diff: https://reviews.apache.org/r/61949/diff/2/ Changes: https://reviews.apache.org/r/61949/diff/1-2/ Testing ------- will fix unit tests Thanks, Dmitro Lisnichenko