> On Sept. 7, 2017, 5:40 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/kerberos.json > > Lines 37-39 (original), 34-36 (patched) > > <https://reviews.apache.org/r/62157/diff/1/?file=1817582#file1817582line37> > > > > Shouldn't this be removed as well?
Updated the change in latest patch - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62157/#review184846 ----------------------------------------------------------- On Sept. 8, 2017, 7 a.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62157/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2017, 7 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Robert > Levas. > > > Bugs: AMBARI-21904 > https://issues.apache.org/jira/browse/AMBARI-21904 > > > Repository: ambari > > > Description > ------- > > /smokeuser entry in RANGER_KMS_SERVER component section is not needed. It > wont break anything, but it is redundant and should eventually be removed. > (Feedback from review request - https://reviews.apache.org/r/34561/) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > 07ae0c2 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/kerberos.json > 69d6b6c > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/kerberos.json > a54783e > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java > 2e16754 > > ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_ranger_kms.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62157/diff/2/ > > > Testing > ------- > > mvn -DskipPythonTests -Drat.skip -Dtest=UpgradeCatalog260Test test > > [INFO] ------------------------------------------------------- > [INFO] T E S T S > [INFO] ------------------------------------------------------- > [INFO] Running org.apache.ambari.server.upgrade.UpgradeCatalog260Test > [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.772 > s - in org.apache.ambari.server.upgrade.UpgradeCatalog260Test > [INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0 > [INFO] > [INFO] > [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-server --- > [INFO] RAT will not execute since it is configured to be skipped via system > property 'rat.skip'. > [INFO] > [INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server --- > [INFO] skipping execute as per configuraion > [INFO] > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- > [INFO] Starting audit... > Audit done. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 42.247 s > [INFO] Finished at: 2017-09-07T14:28:04+00:00 > [INFO] Final Memory: 52M/803M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Mugdha Varadkar > >
