----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62216/ -----------------------------------------------------------
(Updated Sept. 11, 2017, 3:03 p.m.) Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader. Changes ------- changed runOneIteration() too Bugs: AMBARI-21922 https://issues.apache.org/jira/browse/AMBARI-21922 Repository: ambari Description ------- There is a type of alert known as a "SERVER" alert which is a Java class that runs inside of the Ambari Server. We use these alerts to check for specific issues with the Ambari Server itself. However, nothing should prevent a cluster's services from being able to define one of these. Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java d71429c ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java de203be ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java b8058c8 ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 33d9b3d Diff: https://reviews.apache.org/r/62216/diff/2/ Changes: https://reviews.apache.org/r/62216/diff/1-2/ Testing ------- - creted a zookeeper alert with sourceType = 'SERVER' and schedule interval 1 minute - waited one minute - checked that alert was scheduled and executed by the ambari server existing tests: Tests run: 4882, Failures: 0, Errors: 0, Skipped: 37 Ran 457 tests in 98.074s OK 1 unrelated failure: FAIL: test_start_secured (test_zeppelin_master.TestZeppelinMaster) Thanks, Attila Magyar