----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62628/#review186565 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Sept. 27, 2017, 8:53 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62628/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 8:53 p.m.) > > > Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene > Chekanskiy, Jonathan Hurley, Laszlo Puskas, Robert Nettleton, and Sebastian > Toader. > > > Bugs: AMBARI-22072 > https://issues.apache.org/jira/browse/AMBARI-22072 > > > Repository: ambari > > > Description > ------- > > Allow for backward compatibility in how identity references are specified by > checking to see of the "name" attribute of an identity descriptor is a path > to a referenced identity descriptor. However a warning should be posted to > the log. > > Note: Most of the changes here are resurrected code that was removed with > patch from https://issues.apache.org/jira/browse/AMBARI-21919. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java > 4255dd12d4 > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java > 0c7a9a996f > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java > d0d57d5d23 > > > Diff: https://reviews.apache.org/r/62628/diff/1/ > > > Testing > ------- > > ``` > ------------------------------------------------------------------------------- > Test set: org.apache.ambari.server.stack.KerberosDescriptorTest > ------------------------------------------------------------------------------- > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.033 s - in > org.apache.ambari.server.stack.KerberosDescriptorTest > ``` > ``` > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 35:23 min > [INFO] Finished at: 2017-09-27T16:29:47-04:00 > [INFO] Final Memory: 70M/591M > [INFO] > ------------------------------------------------------------------------ > ``` > > > Thanks, > > Robert Levas > >