----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review187037 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py Lines 21 (patched) <https://reviews.apache.org/r/62756/#comment263992> Can we also remove the duplicate code in HDP stack advisors? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py Lines 466 (patched) <https://reviews.apache.org/r/62756/#comment263991> Fix Typo "AMS Validator" instead of "Storm Validator" - Jayush Luniya On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62756/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2017, 7:48 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Sid Wagle. > > > Bugs: AMBARI-22124 > https://issues.apache.org/jira/browse/AMBARI-22124 > > > Repository: ambari > > > Description > ------- > > We need to move AMS specific logic in the stack advisors to service advisor. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py > a2e31cc > > > Diff: https://reviews.apache.org/r/62756/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >