> On Oct. 5, 2017, 10:26 a.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > > Lines 478 (patched) > > <https://reviews.apache.org/r/62785/diff/1/?file=1846548#file1846548line478> > > > > what does 0.35/0.09 mean here? Would it play well for big/small numbers > > of tasks? > > Nate Cole wrote: > It means that their respective status contribute 9% and 35% to the total > progress. It's weak, but it's how CalculatedStatus does it too.
There are the same values used by CalculatedStatus - it's not done per task, either - it's done via total number of tasks in the request. So, this is saying that "All Queued tasks in the request will account for 9% of the total progress - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62785/#review187184 ----------------------------------------------------------- On Oct. 5, 2017, 9:01 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62785/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2017, 9:01 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-22144 > https://issues.apache.org/jira/browse/AMBARI-22144 > > > Repository: ambari > > > Description > ------- > > When performing an upgrade, hitting pause jumps your progress right to 100%. > So if you're at 63%, as soon as you hit Pause it goes to 100%. As soon as > you hit "Resume", it will go back to 63%. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > a28fb02f52 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 7b9307854a > > > Diff: https://reviews.apache.org/r/62785/diff/1/ > > > Testing > ------- > > Manual. Unit test: > > [INFO] Results: > [INFO] > [WARNING] Tests run: 4915, Failures: 0, Errors: 0, Skipped: 34 > [INFO] > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:53.175s > [INFO] Finished at: Thu Oct 05 10:49:21 EDT 2017 > [INFO] Final Memory: 79M/1940M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
