> On Oct. 7, 2017, noon, Oliver Szabo wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > > Lines 2783 (patched) > > <https://reviews.apache.org/r/62809/diff/1/?file=1847507#file1847507line2783> > > > > can these variables calculated at params.py in the stack code instead > > of putting to the BlueprintConfigurationProcessor? (using jinja2 variables > > at configurations - you can get the proper hosts from command.json input). > > just because the ambari server java code could be independent from druid. > > im not too big fan of this class, we should get rid of it sooner or later > > > > but you can drop this issue if zou do not want to do it, it's just a > > reccomendation from me. > > Attila Doroszlai wrote: > I agree that this class stinks. However, currently no `%HOSTGROUP::...%` > substitution occurs in Python code. I guess it shouldn't be introduced at > this point before 2.6 release. > > Oliver Szabo wrote: > no need for %HOSTGROUP::.. substitution. It can be a jinja variable like > {{ metadata_connector_connect_uri }}. > like for logsearch and ambari infra solr, there are some refrerences for > zookeeper but you cannot find that in the BlueprintConfigurationProcessor > class
Hi Oliver, I don't think the python substitution you mentioned will totally work. While the substitution might work on the agent side, I've seen cases where this type of substitution won't show up properly on the UI, meaning that the UI will show the jinja variable tokens in the config properties, which is not the correct behavior. I agree that the BlueprintConfigurationProcessor should eventually be removed, but the problem is that the stack metadata doesn't hold enough information yet about topology data to allow this class to be refactored or removed just yet. Thanks, Bob - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62809/#review187335 ----------------------------------------------------------- On Oct. 9, 2017, 12:43 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62809/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2017, 12:43 p.m.) > > > Review request for Ambari, Nishant Bangarwa, Slim Bouguerra, Sandor Magyari, > Swapan Shridhar, and Sebastian Toader. > > > Bugs: AMBARI-22159 > https://issues.apache.org/jira/browse/AMBARI-22159 > > > Repository: ambari > > > Description > ------- > > Replace placeholders in `metastore_hostname`, > `druid.metadata.storage.connector.connectURI` and `druid.zk.service.host` > when creating cluster via blueprint. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 5a6e2cc0de7dc0c0f4499624e21c43bbc8d24b54 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 68d6349db0207ab6df44b4b0a341c77ecabc46ea > > > Diff: https://reviews.apache.org/r/62809/diff/2/ > > > Testing > ------- > > Tested manually on local cluster. > > Unit tests pass: `Tests run: 4900, Failures: 0, Errors: 0, Skipped: 36` > > > Thanks, > > Attila Doroszlai > >
