----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62851/#review187486 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java Lines 149 (patched) <https://reviews.apache.org/r/62851/#comment264513> Should we move this around the switch statement in case anymore case's are added in the future which should also be skipped? - Jonathan Hurley On Oct. 9, 2017, 5:19 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62851/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2017, 5:19 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-22178 > https://issues.apache.org/jira/browse/AMBARI-22178 > > > Repository: ambari > > > Description > ------- > > The HostVersionOutOfSyncListener is incorrectly setting ALL other > host_version records to OUT_OF_SYNC other than what the newly-added component > is for. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > 78744613ed > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > 076190a47d > > > Diff: https://reviews.apache.org/r/62851/diff/1/ > > > Testing > ------- > > Manual added host and added new service to verify records. Unit tests > pending. > > > Thanks, > > Nate Cole > >
