----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/#review187878 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62949/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 4:46 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-22226 > https://issues.apache.org/jira/browse/AMBARI-22226 > > > Repository: ambari > > > Description > ------- > > The code to check versions was only looking at the upgrade context repo > version, not the target service repo > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java > f80d06accc > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 0ce5d30b0b > > > Diff: https://reviews.apache.org/r/62949/diff/1/ > > > Testing > ------- > > No new tests, just verify existing tests pass. > Manual. Unit pending. > > > Thanks, > > Nate Cole > >