-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/#review188291
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
Line 174 (original), 174 (patched)
<https://reviews.apache.org/r/62930/#comment265291>

    Please use `{safemode_check}` for the first part of the command instead of 
repeating the contents.



ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
Line 175 (original), 175 (patched)
<https://reviews.apache.org/r/62930/#comment265289>

    Need to pass `user=user` to the `call` function for the command to be run 
as the HDFS user.


- Attila Doroszlai


On Oct. 12, 2017, 4:22 p.m., Piyush Chavhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62930/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-22187
>     https://issues.apache.org/jira/browse/AMBARI-22187
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If ambari-server and ambari-agents running using non-root user and tried to 
> upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to 
> "get safemode state" fails for NameNode
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
>  5969fcf 
> 
> 
> Diff: https://reviews.apache.org/r/62930/diff/1/
> 
> 
> Testing
> -------
> 
> Tested this change on the running cluster by performing express upgrade from 
> BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on 
> the cluster.
> 
> UTs are still running for this.
> 
> 
> Thanks,
> 
> Piyush Chavhan
> 
>

Reply via email to