-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63143/#review188670
-----------------------------------------------------------


Ship it!




Ship It!

- Andrii Tkach


On Oct. 19, 2017, 12:13 p.m., Andrii Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63143/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 12:13 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-22269
>     https://issues.apache.org/jira/browse/AMBARI-22269
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Implement tabs to switch between Service and Audit Logs
> - Edit related components and services so that they can work with user 
> navigation between different kinds of logs
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 12b95a7 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/filtering.ts 
> PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/app-state.ts 
> beeb670 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/store.ts 
> c62d3ee 
>   ambari-logsearch/ambari-logsearch-web/src/app/classes/models/tab.ts 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/collapsible-panel/collapsible-panel.component.spec.ts
>  60b7d63 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-button/dropdown-button.component.spec.ts
>  e795986 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/dropdown-list/dropdown-list.component.spec.ts
>  759a0e1 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-button/filter-button.component.spec.ts
>  4e6f460 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
>  f5b9330 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.html
>  22ec8fe 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.spec.ts
>  0643ea6 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/filters-panel/filters-panel.component.ts
>  5eef03e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-context/log-context.component.spec.ts
>  c21750a 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.html
>  8b63278 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.less
>  cd28efc 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.spec.ts
>  9b3a043 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-container/logs-container.component.ts
>  cdc023d 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
>  b27eb69 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.ts
>  2462a61 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.html
>  7e3621a 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.less
>  b596a3d 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.spec.ts
>  bbbebdf 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/main-container/main-container.component.ts
>  ad86a74 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/menu-button/menu-button.component.spec.ts
>  5414f4f 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.html
>  be6591b 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/pagination/pagination.component.ts
>  d38d0d8 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/tabs/tabs.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/tabs/tabs.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/tabs/tabs.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/tabs/tabs.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-histogram/time-histogram.component.less
>  6fe6292 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.spec.ts
>  08817f4 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/time-range-picker/time-range-picker.component.ts
>  fc0f6ae 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/timezone-picker/timezone-picker.component.spec.ts
>  7105624 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.spec.ts
>  3dbd992 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/component-actions.service.ts
>  19b873c 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/component-generator.service.spec.ts
>  f043f42 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.spec.ts
>  5d79902 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/filtering.service.ts 
> c3177cc 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.spec.ts
>  a762fef 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/logs-container.service.ts
>  0319262 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/storage/reducers.service.ts
>  ca8a632 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/services/storage/tabs.service.ts
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web/src/assets/i18n/en.json 99ddbe5 
> 
> 
> Diff: https://reviews.apache.org/r/63143/diff/1/
> 
> 
> Testing
> -------
> 
> Executed 108 of 108 SUCCESS (3.318 secs / 3.295 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Reply via email to