> On Nov. 9, 2017, 1:40 p.m., Nate Cole wrote: > > ambari-server/src/main/python/os_check_type.py > > Line 33 (original), 33 (patched) > > <https://reviews.apache.org/r/63666/diff/1/?file=1884776#file1884776line33> > > > > Previous message was a bit more informative. We may want something > > more descriptive here other than just the os type
We want to use current_os value from stdout in bootstrap.py script as retcode["log"], let me know if descriptive message is necessary. We can make the print message as "OS type of current host is : redhat6" and split the log message in bootstrap.py based on ':'. - Yussuf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63666/#review190581 ----------------------------------------------------------- On Nov. 8, 2017, 2:27 p.m., Yussuf Shaikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63666/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 2:27 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22327 > https://issues.apache.org/jira/browse/AMBARI-22327 > > > Repository: ambari > > > Description > ------- > > For setting up Ambari hybrid cluster we need to allow different OS types for > agent hosts as compared to the server OS type. > The strict check during bootstrap needs to be changed in os_check_type.py > > > Diffs > ----- > > ambari-server/src/main/python/os_check_type.py 34de34b > ambari-server/src/test/python/TestOSCheck.py 9aba78b > > > Diff: https://reviews.apache.org/r/63666/diff/1/ > > > Testing > ------- > > test_os_type_check (TestOSCheck.TestOSCheck) ... ok > > > Thanks, > > Yussuf Shaikh > >
