----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63749/#review190828 -----------------------------------------------------------
Ship it! Ship It! - Balázs Bence Sári On Nov. 13, 2017, 8:56 a.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63749/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 8:56 a.m.) > > > Review request for Ambari, Andrii Babiichuk, Andrii Tkach, Balázs Bence Sári, > and Nate Cole. > > > Bugs: AMBARI-22424 > https://issues.apache.org/jira/browse/AMBARI-22424 > > > Repository: ambari > > > Description > ------- > > OneFS mpack should have a quicklink definition with links that point to the > OneFS admin UI. > > OneFS is a client only service and the hostname of OneFS admin page is an > external host. The quicklink engine needed to be improved to allow overriding > hostnames. > > For example the following quicklink will point to http://scisilon.fqdn if > core-site/fs.defaultFS=hdfs://scisilon.fqdn. > > "links": [ > { > "component_name" : "ONEFS_CLIENT", > "name": "onefs_web_ui", > "label": "OneFS Web UI", > "url": "%@://%@", > "host": { > "http_property": "fs.defaultFS", > "site": "core-site" > } > } > ] > } > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Host.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java > 1d2e712 > > ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java > aac278d > ambari-server/src/test/resources/child_quicklinks_to_override.json 4309532 > ambari-web/app/views/common/quick_view_link_view.js 5888acb > ambari-web/test/views/common/quick_link_view_test.js 1998a9c > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/metainfo.xml > 82e2022 > > contrib/management-packs/isilon-onefs-mpack/src/main/resources/addon-services/ONEFS/1.0.0/quicklinks/quicklinks.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63749/diff/1/ > > > Testing > ------- > > - installed mpack and clicked on quicklinks > > existing tests: passed > > > Thanks, > > Attila Magyar > >
