> On Dec. 13, 2017, 9:22 a.m., Krisztian Kasa wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigItem.java > > Line 62 (original), 64 (patched) > > <https://reviews.apache.org/r/64553/diff/3/?file=1914915#file1914915line64> > > > > Create an abstract init method and call it from here. The comment "This > > method needs to be overwritten by deriving classes." would be unnecessary. > > Like: > > > > protected abstract onInitializing(LogFeederProps logFeederProps); > > > > public void init(LogFeederProps logFeederProps) throws Exception { > > this.logFeederProps = logFeederProps; > > onInitializing(logFeederProps); > > }
you are right but as i wrote it does not contain any real changes on the blocks part (focus is on make it work with spring boot), so these will be refactored in different patch > On Dec. 13, 2017, 9:22 a.m., Krisztian Kasa wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java > > Lines 213 (patched) > > <https://reviews.apache.org/r/64553/diff/3/?file=1914921#file1914921line213> > > > > Are the same properties are stored here as the fields of this class? no its all properties, so you can pass all of them if you want through this class > On Dec. 13, 2017, 9:22 a.m., Krisztian Kasa wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederSecurityConfig.java > > Lines 160 (patched) > > <https://reviews.apache.org/r/64553/diff/3/?file=1914922#file1914922line160> > > > > Isn't it isEmpty? yes, thanks > On Dec. 13, 2017, 9:22 a.m., Krisztian Kasa wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/StatsLogger.java > > Lines 64 (patched) > > <https://reviews.apache.org/r/64553/diff/3/?file=1914936#file1914936line64> > > > > Wouldn't be better to halt the entire application in case of an Error? > > So Errors would be rethrown but Exceptions not. regarding the 2 statLogger comment: probably it will be refactored much more (or i will get rid of this), but now i just moved the class (but review board show as a newly added one) - Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64553/#review193647 ----------------------------------------------------------- On Dec. 13, 2017, 3:24 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64553/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 3:24 p.m.) > > > Review request for Ambari, Krisztian Kasa and Sid Wagle. > > > Bugs: AMBARI-22639 > https://issues.apache.org/jira/browse/AMBARI-22639 > > > Repository: ambari > > > Description > ------- > > First patch for refactor logfeeder - Spring Boot support > > Add spring boot support, the goal is to get rid of LogFeederPropertiesUtil > and let Spring to handle configs & beans. > - remove LogFeederPropertiesUtil > - move logfeeder properties fields into mutliple POJOs > - update some tests & remove one test (needs to rewrite it) > - convert singleton classes to spring beans > - let Spring to handle application pid file > - convert some internal threads to classes (like StatsLogger) > > (it does not contain any real changes regarding to input-filter-output blocks) > > Next patch will be focus on the usage of start scritps (in ambari-logsearch > and ambari-server stack code) > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java > a84a97b > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeeder.java > 6ed36fd > ambari-logsearch/ambari-logsearch-logfeeder/.gitignore PRE-CREATION > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 01710bf > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > 5114743 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederCommandLine.java > d996f98 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java > 243b344 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigItem.java > 5c20a8e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogEntryParseTester.java > ec29f69 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java > a7cccc6 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/ApplicationConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/InputSimulateConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogEntryCacheConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederSecurityConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/MetricsCollectorConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java > 8e8834b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java > fc7a565 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java > 8e5aee8 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java > b021c37 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 972011d > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java > 8f8c4fd > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java > f1b422f > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java > df6c941 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java > 6173f53 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java > e44873b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java > c832358 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java > 6e8ac04 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/StatsLogger.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputFile.java > e1a0bb9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java > ba4d60a > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputKafka.java > 52fc6f8 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java > 48716fa > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputS3File.java > 5b213e8 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java > 38219df > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederPropertiesUtil.java > 1636653 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java > 6bcaac9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log-samples/shipper-conf/input.config-sample.json > 4ab2eb2 > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml > eb20665 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties > 115778b > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterGrokTest.java > 8d7e86c > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterJSONTest.java > acc3d4d > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/filter/FilterKeyValueTest.java > ae978fb > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputFileTest.java > efebc08 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/input/InputManagerTest.java > 46fbc3b > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java > 46abc63 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java > f74a80e > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputKafkaTest.java > 38d4b8b > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputManagerTest.java > 5abb720 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputS3FileTest.java > 7c6aca2 > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java > 5ab271a > > > Diff: https://reviews.apache.org/r/64553/diff/4/ > > > Testing > ------- > > unit tests done. Check behavior from IDE + docker-compose env > > > Thanks, > > Oliver Szabo > >
