> On Jan. 2, 2018, 11:51 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > > Line 633 (original) > > <https://reviews.apache.org/r/64887/diff/1/?file=1929460#file1929460line633> > > > > It's much more convenient to keep JAVA_HOME in one place. We want to > > centralize (as much as we can) the places where we have to remember to set > > JAVA_HOME. Can you pass in the os type or OS (the object0 here instead? > > Yussuf Shaikh wrote: > Here we do not know the os type of each host. This method is called > initially during stage creation. Hence had introduced a method in > Configuration class which is called in hosts loop later for different flows.
Fair enough - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64887/#review194635 ----------------------------------------------------------- On Jan. 3, 2018, 2:03 a.m., Yussuf Shaikh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64887/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 2:03 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-22403 > https://issues.apache.org/jira/browse/AMBARI-22403 > > > Repository: ambari > > > Description > ------- > > Java side changes required to read JAVA HOME value for each host depending on > the OS type eg: java.home.redhat7. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 182cd58 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > c0a7a7b > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > c4df0b1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 198b617 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > dcafdea > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > b6287e6 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > e47fcd2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 6bece66 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > e795d28 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > a1f28f1 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > c5994c5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 51035ba > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java > 670c187 > > ambari-server/src/test/java/org/apache/ambari/server/utils/StageUtilsTest.java > b90295d > > > Diff: https://reviews.apache.org/r/64887/diff/2/ > > > Testing > ------- > > tests ran on ambari-server project. > > > Thanks, > > Yussuf Shaikh > >
