----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33200/#review80381 -----------------------------------------------------------
Ship it! Please update the description to also mention TestTaskUtil replaces a lot of the custom fixtures used in different test cases. I think it counts for a non trival portion of the diff. - Zameer Manji On April 14, 2015, 5:04 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33200/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 5:04 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This is a ripple from changing StorageEntityUtil.assertFullyPopulated to > require that all primitive fields are using non-default values. This > tightens up the validation that a round-tripped object is not silently > dropping field values. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 23827ab92367f3310c67d213bc8848cbd565234b > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java > b0cced750fe767f6067d0de291677f417c543919 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java > 858069ea8d7393bd82260693ca8499e9569b50ef > src/test/java/org/apache/aurora/scheduler/base/JobsTest.java > a170fb655a4d1877c66b3e27e272647b989e5409 > src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > b8b9c1b8cdf7b641976c583a71fdd9b0c14e6e5f > src/test/java/org/apache/aurora/scheduler/base/TasksTest.java > 2866b20c1a88f6012a6f1c8eec33e450c3510f80 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 7234fd3dfceec4d916807559d5b6604db0864d46 > src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java > e5f3adfa61da665edb063b01b727f75455b0ad02 > src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java > 90a05baa2a1d4fcd73d24d539a0453d6917ac2f6 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > 5853c037d53e707e5df434fc661cd285ed9ecfc4 > > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java > 1f505153f36b355718c778af230a6db4168505a5 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java > 83b238f3c0d218f35db098cf444c08d72798a7a3 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java > b26ddd39f7d972bba41aa72283d0b0626ed0fe64 > src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java > 3f1f72bcf214b8ab9b3d4528ff0eb403c82db00c > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > dd4c94097161477e8161fb7e440e4c41e2a61f21 > src/test/java/org/apache/aurora/scheduler/updater/TaskUtil.java > 0e67f91536ff89c07da9be82049719c854aa3d62 > > Diff: https://reviews.apache.org/r/33200/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
