> On May 12, 2015, 11:08 p.m., Kevin Sweeney wrote: > > examples/vagrant/provision-dev-cluster.sh, line 33 > > <https://reviews.apache.org/r/34126/diff/1/?file=957021#file957021line33> > > > > comment is a lie now, but it seems safe to remove as the > > update-alternatives line is self-explanatory
Thanks, removed. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34126/#review83513 ----------------------------------------------------------- On May 12, 2015, 11:41 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34126/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 11:41 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-274 > https://issues.apache.org/jira/browse/AURORA-274 > > > Repository: aurora > > > Description > ------- > > Two code changes were required: > - a unit test made an assumption about iteration order over a `HashSet` > - a new compiler warning showed up on possible dereference of a null pointer > > Note the first introduction of a lambda as a PoC while modifying a unit test. > > > Diffs > ----- > > NEWS PRE-CREATION > build.gradle ec9b52206ce602d0f4a0a6d4b7fe55d055a787dc > examples/vagrant/provision-dev-cluster.sh > 2c5ce970446f8849b66d7035b8b10b253827db83 > > src/test/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessorTest.java > 218ae0da80f9129107da17004f23098b9507b33d > > src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java > d1301e0ea3c255563709048247772648052e8041 > > Diff: https://reviews.apache.org/r/34126/diff/ > > > Testing > ------- > > ``` > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > Bill Farner > >