-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34300/#review85258
-----------------------------------------------------------
Master (6db13ba) is red with this patch.
./build-support/jenkins/build.sh
Using cached twitter.common.collections-0.3.0.tar.gz
Collecting smmap>=0.8.5 (from
gitdb>=0.5.1->GitPython==0.3.2.RC1->twitter.checkstyle==0.1.0)
Using cached smmap-0.9.0.tar.gz
Collecting twitter.common.string==0.3.0 (from
twitter.common.process==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.string-0.3.0.tar.gz
Collecting twitter.common.options==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.options-0.3.0.tar.gz
Collecting twitter.common.dirutil==0.3.0 (from
twitter.common.log==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.dirutil-0.3.0.tar.gz
Collecting twitter.common.contextutil==0.3.0 (from
twitter.common.util==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.contextutil-0.3.0.tar.gz
Collecting twitter.common.lang==0.3.0 (from
twitter.common.collections==0.3.0->twitter.common.app==0.3.0->twitter.checkstyle==0.1.0)
Using cached twitter.common.lang-0.3.0.tar.gz
Installing collected packages: pyflakes, pep8, smmap, gitdb, GitPython,
twitter.common.lang, twitter.common.string, twitter.common.process,
twitter.common.options, twitter.common.dirutil, twitter.common.log,
twitter.common.contextutil, twitter.common.util, twitter.common.collections,
twitter.common.app, twitter.checkstyle
Running setup.py install for pyflakes
Running setup.py install for pep8
Running setup.py install for smmap
Running setup.py install for gitdb
Running setup.py install for GitPython
Running setup.py install for twitter.common.lang
Running setup.py install for twitter.common.string
Running setup.py install for twitter.common.process
Running setup.py install for twitter.common.options
Running setup.py install for twitter.common.dirutil
Running setup.py install for twitter.common.log
Running setup.py install for twitter.common.contextutil
Running setup.py install for twitter.common.util
Running setup.py install for twitter.common.collections
Running setup.py install for twitter.common.app
Running setup.py install for twitter.checkstyle
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0
twitter.common.options-0.3.0 twitter.common.process-0.3.0
twitter.common.string-0.3.0 twitter.common.util-0.3.0
F401:ERROR src/test/python/apache/aurora/client/test_config.py:019
'temporary_file' imported but unused
|from twitter.common.contextutil import temporary_dir, temporary_file
F401:ERROR src/test/python/apache/aurora/config/test_thrift.py:019 'Map'
imported but unused
|from pystachio import Map, String
F401:ERROR src/test/python/apache/aurora/config/test_thrift.py:019 'String'
imported but unused
|from pystachio import Map, String
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On May 26, 2015, 9:03 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34300/
> -----------------------------------------------------------
>
> (Updated May 26, 2015, 9:03 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-739
> https://issues.apache.org/jira/browse/AURORA-739
>
>
> Repository: aurora
>
>
> Description
> -------
>
> It's possible to define nested refs that can cause the executor to stack
> trace, e.g.
> {{derp[{{thermos.ports[http]}}]}} is perfectly valid but crashes the executor.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/config/__init__.py
> dd2f89014a3da730364b14e01c499ac0f2c288c1
> src/main/python/apache/aurora/config/schema/base.py
> a87524a8b3ad5aa0e337e0a0028cecb85865b4e6
> src/main/python/apache/aurora/config/thrift.py
> 810febb637d168b07c4aea77984e1d1451a39af2
> src/main/python/apache/aurora/executor/common/task_info.py
> d110faf08135d94d9af95ad74613950c56248c09
> src/main/python/apache/thermos/config/dsl.py
> 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd
> src/main/python/apache/thermos/config/loader.py
> d77ab9a52b16e9d65acdb95f01fd251ae8ab2b6e
> src/test/python/apache/aurora/client/test_config.py
> c56779712b91f621261358aa7ebd6c4fc65446a0
> src/test/python/apache/aurora/config/test_thrift.py
> 654c0b5ae82c98db163c7a44301ff6b23e19b211
> src/test/python/apache/aurora/executor/common/test_task_info.py
> 102ba531aa6c28f2d74bd0d7f1668e5861e3a6b8
>
> Diff: https://reviews.apache.org/r/34300/diff/
>
>
> Testing
> -------
>
> Added some regression tests.
>
>
> Thanks,
>
> Brian Wickman
>
>
