> On May 27, 2015, 8:58 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java, line 82 > > <https://reviews.apache.org/r/34733/diff/1/?file=973043#file973043line82> > > > > Move this validation to the constructor so that it will halt injector > > creation.
Thanks, came to the same conclusion when trying to simplify tests. Done. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34733/#review85438 ----------------------------------------------------------- On May 27, 2015, 8:52 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34733/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 8:52 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-1339 > https://issues.apache.org/jira/browse/AURORA-1339 > > > Repository: aurora > > > Description > ------- > > The current default value leads to overflow. Fixed the value and added > validation. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 5f24668265d02b42cf7a05db4f9bc73d8daef0a7 > src/main/java/org/apache/aurora/scheduler/async/TaskReconciler.java > 23f5f648d3404495e3e9e878592c2638621ce89a > src/test/java/org/apache/aurora/scheduler/async/TaskReconcilerTest.java > f56ffd2d7c584042b5c47fa4dba83f35433762f5 > > Diff: https://reviews.apache.org/r/34733/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
