> On June 3, 2015, 9:01 a.m., Maxim Khutornenko wrote: > > I understand it may be too much for this scope but we should really address > > AURORA-1193 to improve user experience for all status update reasons, not > > just OOM. Giving it a ship it as a stop gap solution.
Agreed, but that is a larger scope which I do not want to tackle. Fixing this TODO will ensure our behaviour does not regress in future mesos versions however. > On June 3, 2015, 9:01 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 187 > > <https://reviews.apache.org/r/34967/diff/2/?file=977048#file977048line187> > > > > Remove MEMORY_LIMIT_EXCEEDED as it's no longer referenced. Done. > On June 3, 2015, 9:01 a.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java, lines > > 226-227 > > <https://reviews.apache.org/r/34967/diff/2/?file=977049#file977049line226> > > > > any particular reason for this change? No, reverted. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34967/#review86343 ----------------------------------------------------------- On June 2, 2015, 6:11 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34967/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 6:11 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1341 > https://issues.apache.org/jira/browse/AURORA-1341 > > > Repository: aurora > > > Description > ------- > > Use TaskStatus Reason to set memory limit message instead of checking the > contents of the message field. Future versions of Mesos can change the > diagnostic information in the message field causing Aurora to display no > information when a task fails. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java > 5af691d0ac959cf4b5d01752daf996803e91ed16 > src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java > fe2fc954350b42487151fc820ebad22a41aeb039 > > Diff: https://reviews.apache.org/r/34967/diff/ > > > Testing > ------- > > ./gradlew test -Pq > > > Thanks, > > Zameer Manji > >
