> On June 11, 2015, 10:55 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/executor/test_thermos_task_runner.py, line 199 > > <https://reviews.apache.org/r/32973/diff/7/?file=982578#file982578line199> > > > > Any particular reason why this skipif moved down here?
I accidentally uploaded the code to always run the skipped tests, uploading correct version now. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32973/#review87644 ----------------------------------------------------------- On June 11, 2015, 10:39 a.m., Brian Brazil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32973/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 10:39 a.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-1257 > https://issues.apache.org/jira/browse/AURORA-1257 > > > Repository: aurora > > > Description > ------- > > Fix name of test for sigterm being ignored. > > Based on > https://github.com/tellapart/incubator-aurora/commit/c90532d69d69045c545004451e3660f5282e6e34 > > > Diffs > ----- > > docs/configuration-reference.md fb753ead94fcd1ed76352306391d356652934a4e > src/main/python/apache/aurora/common/http_signaler.py > 531f1fecbcbf8015175c7f1cb1e1c4d3e7d1268a > src/main/python/apache/aurora/executor/thermos_task_runner.py > 837ad5c55b4a02215a8d509c211e80529536f705 > src/main/python/apache/thermos/config/schema_base.py > f9143cc1b83143d6147f59d90c79435d055d0518 > src/test/python/apache/aurora/common/test_http_signaler.py > c6a21708eb997f213f4cca038891a84f6c5218d4 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py > 1e21a112efcbd0a575fb8d90f78ff1e8c7f034cf > > Diff: https://reviews.apache.org/r/32973/diff/ > > > Testing > ------- > > Unittests and manually in vagrant cluster. Also verified that the flaky tests > pass. > > > Thanks, > > Brian Brazil > >