-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35587/#review88388
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java (line 
198)
<https://reviews.apache.org/r/35587/#comment140903>

    A bit more context will help future readers.  You could mention that 
reconciliation is expected to result in many no-op status updates.



src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
(line 314)
<https://reviews.apache.org/r/35587/#comment140904>

    What's being tested here?  If i'm reading correctly, this test case would 
pass before the patch.


- Bill Farner


On June 18, 2015, 1:02 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35587/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 1:02 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Suppress task reconciliation status update logging.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
> f233d5a181bb1f43fbbfe657dbda2cf975aa6895 
>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
> f0f9ac392973a276028aee3e06517a6e6d960bb6 
> 
> Diff: https://reviews.apache.org/r/35587/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to