----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34337/#review88676 -----------------------------------------------------------
Ship it! Master (d240926) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On June 20, 2015, 11:42 p.m., Mauricio Garavaglia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34337/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 11:42 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Support Arbitrary Docker Parameters in DockerContainer > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > d740a90e7732f42b43a79f8cf0afe705c061539c > docs/configuration-reference.md 7bfd63381f54b0fe5ef6a4f17b825049b19038db > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > e934f570e4a728470408970485abe0809487d312 > src/main/python/apache/aurora/config/schema/base.py > ec9f983564516afe542ab277d987d4d391f87e45 > src/main/python/apache/aurora/config/thrift.py > 810febb637d168b07c4aea77984e1d1451a39af2 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 > > Diff: https://reviews.apache.org/r/34337/diff/ > > > Testing > ------- > > Used Docker as the container of a Job. Included volumes and label parameters > which are correctly picked up by mesos when starting the task. The docker > container gets the specified label and bind mounts the volumes correctly. > I've been running multiple PostgreSQL databases docker containers for several > weeks deploying them as aurora jobs. > > > Thanks, > > Mauricio Garavaglia > >