----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88802 -----------------------------------------------------------
Ship it! Thanks! src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line 65) <https://reviews.apache.org/r/35498/#comment141384> Missing "." src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line 70) <https://reviews.apache.org/r/35498/#comment141385> Same here. - Maxim Khutornenko On June 21, 2015, 2:39 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35498/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 2:39 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-1350 > https://issues.apache.org/jira/browse/AURORA-1350 > > > Repository: aurora > > > Description > ------- > > Compute SLA stats for non-prod jobs > > This is a first iteration closely following the design proposal of Maxim as > posted on the mailinglist. Feedback welcome. > > > Diffs > ----- > > docs/sla.md 14e9108fda91200bbf56384c96b9cd926689311f > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java > 82f36d5ca15df18bdc8ebbbd868d3394db38e603 > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > ff73ca6265bd0699791da5e5b6ed4aab9156d9e4 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 64e986fb2e0f955dd4a9c7824eac9494728bf24e > src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java > cb98834e925793fc116814371548a30470830164 > src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java > 5ee123a03e3c8670e0c03b05c48a9f4c66f6af9d > > Diff: https://reviews.apache.org/r/35498/diff/ > > > Testing > ------- > > `./gradlew -Pq build` and a manual verification in Vagrant. > > > Thanks, > > Stephan Erb > >