----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review89007 -----------------------------------------------------------
Ship it! LGTM so long as end-to-end tests come up green. docs/storage-config.md (line 103) <https://reviews.apache.org/r/35760/#comment141602> Consider a significantly higher number as the advice to make it clear, e.g. 365days. src/main/java/org/apache/aurora/scheduler/SchedulerModule.java (line 104) <https://reviews.apache.org/r/35760/#comment141603> while you're here, remove this newline - Bill Farner On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35760/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 2:24 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1334 > https://issues.apache.org/jira/browse/AURORA-1334 > > > Repository: aurora > > > Description > ------- > > Jave side of changes for removing gc executor support. > > TaskLauncher refactoring will be addressed in a separate diff. > > > Diffs > ----- > > config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d > debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2 > debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4 > debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba > docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a > examples/scheduler/scheduler-local.sh > 6253d505f9851aea613bc95c15c313b03b57af11 > examples/vagrant/upstart/aurora-scheduler-kerberos.conf > 414539b1917b5d33c577f1539575934c7f7c8167 > examples/vagrant/upstart/aurora-scheduler.conf > f4b867cbbcdbcc792518c2f90807834e47dce253 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 6edec22aba135136c4ce4066b9535f23de077db7 > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 8bcac6c4f93eaca7250d43ab81a72102b91bf836 > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java > f2ef70ddc5a859811f0e6c2ade62e115639c1654 > src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java > d2ec944ca12456c23eb54c9be8b1e6756f35e7f1 > src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java > ec43a44d9cbd0f303e4833953cdb65664d5ed569 > > Diff: https://reviews.apache.org/r/35760/diff/ > > > Testing > ------- > > > Thanks, > > Maxim Khutornenko > >
