----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ -----------------------------------------------------------
(Updated June 25, 2015, 11:32 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Changes ------- Move GuavaCollectors to existing GuiceUtils class. Repository: aurora Description ------- Use java.util.Optional and streams in Lock*. Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API Diffs (updated) ----- src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53 src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386 src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965 Diff: https://reviews.apache.org/r/35842/diff/ Testing ------- ./gradlew -Pq build Thanks, Kevin Sweeney