> On June 29, 2015, 5:55 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 244 > > <https://reviews.apache.org/r/35990/diff/1/?file=994197#file994197line244> > > > > I have been thinking about using mesos task labels to record the aurora > > job key. If we blindly copy the metadata over to the task labels, this > > might prevent us from doing that task in a backwards compatible manner. > > > > Perhaps the label keys should be prefixed?
Using the components of a jobkey as labels is an excellent idea. Latest Mesos allows label injection using hooks at the master and slave level. I guess we should opt for an aurora specific prefix. How about `aurora_metadata_` as a prefix? - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review89750 ----------------------------------------------------------- On June 28, 2015, 10:44 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35990/ > ----------------------------------------------------------- > > (Updated June 28, 2015, 10:44 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-1052 > https://issues.apache.org/jira/browse/AURORA-1052 > > > Repository: aurora > > > Description > ------- > > Map Aurora task metadata to Mesos task labels > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > e934f570e4a728470408970485abe0809487d312 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9 > > Diff: https://reviews.apache.org/r/35990/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
