----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89965 -----------------------------------------------------------
Ship it! One nit, but i don't feel strongly about it. src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java (line 156) <https://reviews.apache.org/r/35954/#comment142868> It would be nice if comparison logic resided in QuotaCheckResult alongside the quota overage checks. - Bill Farner On June 30, 2015, 12:06 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35954/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 12:06 a.m.) > > > Review request for Aurora, Joe Smith, Maxim Khutornenko, and Bill Farner. > > > Bugs: AURORA-1375 > https://issues.apache.org/jira/browse/AURORA-1375 > > > Repository: aurora > > > Description > ------- > > Having quota below current production resesrvation is illogical and the > scheduler should reject requests that would result in this. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java > 7453680af5a518012f9779f82d0349e897c04994 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 9af379c36d2e3e44f462ed5d431f8a497b2d09f6 > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java > 58ee226a3819d6796a169156320c10677e35611a > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > ee8f5423810c60b2075e6b98ba8cda36393ae5cc > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 2a2b499905a788eb59f5824bc66b487f91e838f1 > > Diff: https://reviews.apache.org/r/35954/diff/ > > > Testing > ------- > > ./rbt post -o > > > Thanks, > > Zameer Manji > >
