----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36511/#review91780 -----------------------------------------------------------
Ship it! LGTM. I talked through this change with Andrew in IRC yesterday. - Dan Norris On July 15, 2015, 5:50 p.m., Andrew Jorgensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36511/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 5:50 p.m.) > > > Review request for Aurora, Benjamin Staffin, Dan Norris, and Zameer Manji. > > > Bugs: AURORA-1400 > https://issues.apache.org/jira/browse/AURORA-1400 > > > Repository: aurora > > > Description > ------- > > java-runtime-headless is a virtual package and cannot have a version > specified. The consequence of this is that the built packages require > openjdk-8 > be installed which prevented the packages from working with oracle-java8. > java8-runtime-headless is a virtual package provided by both openjdk-8 > and oracle-java8 so the resulting debian packages can be installed on a > machine with either versions of java8 installed. > > > Diffs > ----- > > build-support/packaging/debian/control > ff62ea19f27e1937549aca1c1effd108626453bc > > Diff: https://reviews.apache.org/r/36511/diff/ > > > Testing > ------- > > Started two docker containers, one with oracle-java8 and the other with > openjdk-8. I was able to install the aurora-scheduler package in both > containers with this change. > > > Thanks, > > Andrew Jorgensen > >
